Skip to content

Add shouldBypassTagCache option for incremental caches #944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 3, 2025
Merged

Add shouldBypassTagCache option for incremental caches #944

merged 5 commits into from
Aug 3, 2025

Conversation

conico974
Copy link
Contributor

Introduce a new option to bypass tag cache validation from the incremental caches, along with unit tests to ensure expected behavior.

This is useful in 2 situations:

  • When you don't need the tag cache only for some routes/data cache entry
  • When you're sure that a route has not been revalidated. For example in cloudflare when a cache entry is coming from the cache api and that you have automatic cache invalidation.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Aug 3, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 5eaabb4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@opennextjs/aws Patch
app-pages-router Patch
app-router Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 3, 2025 •
edited
Loading

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 26.53% 2602 / 9807
🔵 Statements 26.53% 2602 / 9807
🔵 Functions 54.26% 140 / 258
🔵 Branches 73.45% 628 / 855
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/open-next/src/adapters/cache.ts 86.76% 83.73% 100% 86.76% 22-23, 87-95, 151-162, 184-185, 370-378, 412-413, 447-456, 466-474
packages/open-next/src/adapters/composable-cache.ts 0% 0% 0% 0% 1-127
packages/open-next/src/types/overrides.ts 0% 0% 0% 0%
Generated in workflow #1400 for commit 5eaabb4 by the Vitest Coverage Report Action

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Aug 3, 2025 •
edited
Loading

Open in StackBlitz

pnpm add https://pkg.pr.new/@opennextjs/aws@944

commit: 5eaabb4

khuezy
khuezy approved these changes Aug 3, 2025
View reviewed changes
Copy link
Contributor

@khuezy khuezy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just 1 note.

@conico974 conico974 merged commit b9635d0 into main Aug 3, 2025
3 checks passed
@conico974 conico974 deleted the conico/bypass-tag-cache branch August 3, 2025 14:26
This was referenced Aug 3, 2025
Merged
Open
@vicb vicb mentioned this pull request Sep 18, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@khuezy khuezy khuezy approved these changes

+1 more reviewer

@sommeeeer sommeeeer sommeeeer left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@conico974 @khuezy @sommeeeer